While other wallet generators certainly have more options, for the general enduser what really matters is being able to generate an address as fast as possible. And in this regard, we now will have a 20x lighter tool.
But that comes at a cost.
Basically everything was built from scratch, including a good part of the actual generator code (cryptographic/math libraries are 3rd-party tho). This could lead to bugs and other inconsistencies, so a review from this code by the core devs would be much appreciated, because yah know… don’t want to disapoint mr. Xavier here right?
tl;dr
please review the code (to help find bugs/security issues), starting from here (check imports for other files where you might want to take a look).
Any other bugs/ideas/whatever can also be posted here.
General look and feel: fantastic! Much better than http://wallet.peercointalk.org/.
Also good that no network communication is happening after initial load.
However, I’m missing some features for a full replacement.
The features I’m missing in order of importance:
BIP38 encryption support (both generation and decryption). I consider this the most important as users should be encouraged to encrypt their keys even when stored on paper.
Private key QR code, nobody wants to type in his private key when spending.
Paper wallet art, it’s always nice to print money and give it to someone.
There is plenty of room for improvements and new features, but that could be added after this basic version goes online. In the meantime, if a heavy user demands advanced options, we can give him the old generator.
Made sure local storage and cookies do not store keys.
Went through the source code to get an idea of the architecture.
One feature that I believe is still needed, is to run some basic tests before showing the keys to make sure the browser correctly supports this tool.
You don’t want people with old browsers accidently sending money to incorrectly generated keys.
Agreed. Right now there isn’t any visual notice for unsupported browsers. Older browsers should be blocked on the spot with a friendly message. Will work on it tonight.
They were imported from this peercoin repo, which in return used this code from a bitcoin address generator. Since any of them seem to have any specific licenses, I guess we can simply add attribution to their Github users.
