Unit tests not compiling


#1

I’ll start fixing them and send a pull request later.

But I’m wondering why they are even not compiling? Is nobody using them?


#2

[quote=“hrobeers, post:1, topic:3807”]I’ll start fixing them and send a pull request later.

But I’m wondering why they are even not compiling? Is nobody using them?[/quote]

Exactly, nobody has been using them ever.


#3

Is there even an interest in having them fixed?
If not, I’ll only fix them in the Peershares code.

I noticed that they have been used for Peershares dividend distribution, and that NuBits have added some in their codebase (altough multiple are failing).

So is there any interest? Or do we keep going without tests?


#4

[quote=“hrobeers, post:3, topic:3807”]Is there even an interest in having them fixed?
If not, I’ll only fix them in the Peershares code.

I noticed that they have been used for Peershares dividend distribution, and that NuBits have added some in their codebase (altough multiple are failing).

So is there any interest? Or do we keep going without tests?[/quote]

As a package maintainer I would like to see them working.


#5

Ok, I’ll start by fixing them in the ppcoin repo.
It’s a good exercise for me to learn the code.

However, there is no point in making them work if the developers aren’t keeping them up to date with their code changes.
Because out-of-date tests are just as useful as no tests to a package maintainer.
So I hope that fixing them will bring them alive.


#6

<3. fixing the unit tests++ :smiley:

i tried a little but ran out of spare time and understanding :\ https://github.com/belovachap/peerennial


#7

I created a pull request that fixes and updates the unit tests to run and succeed for ppcoin!

I really learned a lot about the ppcoin code and enjoyed it very much!

I commented at peer4commit http://peer4commit.com/projects/19. Is that how it works, or should I create a ppcoin-unittest project?

If you like to get the 0.5.2 code with working unit-tests, it’s here: https://github.com/hrobeers/Peershares/tree/ppcoin-master-testfix

I hope it get’s merged, and otherwise I’ll try to get it in the Peershares code.

Enjoy!


#8

[quote=“hrobeers, post:7, topic:3807”]I created a pull request that fixes and updates the unit tests to run and succeed for ppcoin!

I really learned a lot about the ppcoin code and enjoyed it very much!

I commented at peer4commit http://peer4commit.com/projects/19. Is that how it works, or should I create a ppcoin-unittest project?

If you like to get the 0.5.2 code with working unit-tests, it’s here: https://github.com/hrobeers/Peershares/tree/ppcoin-master-testfix

I hope it get’s merged, and otherwise I’ll try to get it in the Peershares code.

Enjoy![/quote]

Thanks!

Someone managing ppcoin project on peer4commit will surely appreciate this effort.


#9

[quote=“hrobeers, post:7, topic:3807”]I created a pull request that fixes and updates the unit tests to run and succeed for ppcoin!

I really learned a lot about the ppcoin code and enjoyed it very much![/quote]

Hi hrobeers,

I will give it a quick review later this week, for the test fix it should not be hard to get in to main. Your work is greatly appreciated!


#10

Thanks Sunny!

I’m quite new here, so still learning how the community works.

I’m happy to hear that you are open to these kind of contributions, so I’ll keep investing time in preparing my Peershare work for merging with the upstream ppcoin code.

Thanks,
hrobeers


#11

Ready for merging!


#12

It’s merged!

https://github.com/ppcoin/ppcoin/pull/112

Thanks Sunny.


#13

Now we wait for new release to see how will this fit with Debian build system :slight_smile:


#14

[quote=“hrobeers, post:12, topic:3807”]It’s merged!

https://github.com/ppcoin/ppcoin/pull/112

Thanks Sunny.[/quote]

Great! Can you push this to https://github.com/peerunity/peerunity as well?


#15

I’ll do that.


#16

Very good :slight_smile:


#17

[quote=“sandakersmann, post:14, topic:3807”][quote=“hrobeers, post:12, topic:3807”]It’s merged!

https://github.com/ppcoin/ppcoin/pull/112

Thanks Sunny.[/quote]

Great! Can you push this to https://github.com/peerunity/peerunity as well?[/quote]

[member=626]sandakersmann[/member]
Done! https://github.com/Peerunity/Peerunity/pull/186
Please merge.


#18

[quote=“hrobeers, post:17, topic:3807”]Done! https://github.com/Peerunity/Peerunity/pull/186
Please merge.[/quote]

Great! I don’t have merge rights, but maybe [member=79]Sunny King[/member] can do it?